DieHard Wolfers

[BrotherTank]

The GunAttack routine looks to see which (if any) enemy is closest to you when you fired the weapon.... It will always attack the closest enemy in your field of view with the damage rate generated at random with no difference for weapon type.

This Mod takes a more realistic approach. It generates the damage to the actor, based on their "distance" (position), and increases the hurtpoints by a defined factor.

Ie: Given x distance and using a machinegun, a damage was generated for "y" guard of lets say 10 hitpoints... My routine then multiplies the 10 by 1.15 and the new damage is now 11 (integer variables drops the decimal point and doesn't round up).

I know it doesn't look like much difference, but the damage is variable based on proximity to gaurd you are attacking. Doing it the way others have suggested defeats the whole purpose of generating the distance to the emeny in the first place and eliminates the randomness of damage based on that distance.

Ie: The closer to the enemy the more accurate your shot, hence more damage.

My mod, keeps this balance. You can change any weapons characteristics very easily, and all other weapons can be added to the routine as well. I'm not saying what you did is wrong, just the solution that I have given is a better balance and realistic.

You can change the strength of any weapon by modifying the "Gun_Attack" routine in the WL_AGENT.C file....

Look for the call to DamageActor (closest, damage) at the end of the routine and modify it something like this:

::: CODE :::

switch (gamestate.weapon)
    {
     case wp_pistol:
          break;
     case wp_machinegun:
          damage = damage * 1.15;
          break;
     case wp_chaingun:
          damage = damage * 1.30;
     }
     
     DamageActor (closest, damage);  // Original code

You can add to it to include all of your firing weapons, and set the damage based on your own personal preferences. Also remember if you are using the same ammo type for all the weapons to adjust the amount used to compensate for this added strength... You want the extra firepower to be used wisely, and make the person think about which weapon they are using and why... Or maybe you don't...

Anyhow.. that is how and where it is done... so enjoy..

Greg
BrotherTank

[Sporb2000]

is that all the code ?

im not entirely competant when it comes to code but i couldnt see much differnt when i upper the values

[BrotherTank]

Sporb2000 wrote:

is that all the code ?

im not entirely competant when it comes to code but i couldnt see much differnt when i upper the values

Yes, that is all the code... You can change the values of 1.15 and 1.30 to whatever you would like. By doing it this way, you still retain the distance factor to the actor, whereas other tutorials don't.

Greg
BrotherTank

[Sporb2000]

OK- This is a real pain in the arse so im gonna ask you to smooth sum stuff over for me
Below is the code in my gun attack routine (im assuing that its the correct area to work in)
i implemented ur code as shown and changed the values a bit .Then i got fed up of
friggin round with vlaues that didnt seem to do any thing so i thought i would do somthin so
rash if it worked it would shurely kill everyone (see WP_chaingun) but that didnt go either
so now im sittin on a flash gun that looks the part but still acts like a flick with a wet towel

::: CODE :::

void   GunAttack (objtype *ob)
{
   objtype *check,*closest,*oldclosest;
   int      damage;
   int      dx,dy,dist;
   long   viewdist;

   switch (gamestate.weapon)
   {
   case wp_pistol:
       damage = damage * 1.00;
      SD_PlaySound (ATKPISTOLSND);
      break;
   case wp_machinegun:
       damage = damage * 1.15;
      SD_PlaySound (ATKMACHINEGUNSND);
      break;
   case wp_chaingun:
      damage = damage * 10.50 + 100;
      SD_PlaySound (ATKGATLINGSND);
      break;
   case wp_mag:
       damage = damage * 1.30;
      SD_PlaySound (ATKMACHINEGUNSND);
      break;
   }
   madenoise = true;

//
// find potential targets
//
   viewdist = 0x7fffffffl;
   closest = NULL;

   while (1)
   {
      oldclosest = closest;

      for (check=ob->next ; check ; check=check->next)
         if ( (check->flags & FL_SHOOTABLE)
         && (check->flags & FL_VISABLE)
         && abs (check->viewx-centerx) < shootdelta
         )
         {
            if (check->transx < viewdist)
            {
               viewdist = check->transx;
               closest = check;
            }
         }

      if (closest == oldclosest)
         return;                  // no more targets, all missed

   //
   // trace a line from player to enemey
   //
      if (CheckLine(closest))
         break;

   }

//
// hit something
//
   dx = abs(closest->tilex - player->tilex);
   dy = abs(closest->tiley - player->tiley);
   dist = dx>dy ? dx:dy;

   if (dist<2)
      damage = US_RndT() / 4;
   else if (dist<4)
      damage = US_RndT() / 6;
   else
   {
      if ( (US_RndT() / 12) < dist)      // missed
         return;
      damage = US_RndT() / 6;
   }

   DamageActor (closest,damage);
}

Did i do sumthin wrong? or am i just over reacting - please help dude before i throw a fit and eat my laptop

[BrotherTank]

Yep... You did something wrong... You didn't follow the tutorial. The tutorial is done the way it is because if you try and merge it up top (like you did) then it doesn't affect the actual damage done, which is calculated below the "switch (gamestate.weapon)" code...

Yes, you could merge the "switch" code, but it must be done just above the "DamageActor (closest,damage);" line.

Hence, to make it work, try moving the your code around to look like this:

::: CODE :::

void GunAttack (objtype *ob)
{
   objtype *check,*closest,*oldclosest;
   int damage;
   int dx,dy,dist;
   long viewdist;

   madenoise = true;

//
// find potential targets
//
   viewdist = 0x7fffffffl;
   closest = NULL;

   while (1)
   {
      oldclosest = closest;

      for (check=ob->next ; check ; check=check->next)
      if ( (check->flags & FL_SHOOTABLE) && (check->flags & FL_VISABLE) && abs (check->viewx-centerx) < shootdelta)
      {
         if (check->transx < viewdist)
         {
            viewdist = check->transx;
            closest = check;
         }
      }

      if (closest == oldclosest) return; // no more targets, all missed
//
// trace a line from player to enemey
//
      if (CheckLine(closest)) break;

   }

//
// hit something
//
   dx = abs(closest->tilex - player->tilex);
   dy = abs(closest->tiley - player->tiley);
   dist = dx>dy ? dx:dy;

   if (dist<2) damage = US_RndT() / 4;
   else if (dist<4) damage = US_RndT() / 6;
   else
   {
      if ( (US_RndT() / 12) < dist) return; // missed
      damage = US_RndT() / 6;
   }
   switch (gamestate.weapon)
   {
      case wp_pistol:
         damage = damage * 1.00;
         SD_PlaySound (ATKPISTOLSND);
         break;
      case wp_machinegun:
         damage = damage * 1.15;
         SD_PlaySound (ATKMACHINEGUNSND);
         break;
      case wp_chaingun:
         damage = damage * 10.50 + 100;
         SD_PlaySound (ATKGATLINGSND);
         break;
      case wp_mag:
         damage = damage * 1.30;
         SD_PlaySound (ATKMACHINEGUNSND);
         break;
   }
   DamageActor (closest,damage);
}

It all makes a difference.

Greg
BrotherTank

[Sporb2000]

Nuts - i knew it would be somthing like that - erm thanks big T

PS - if you ever run out of code to fix that other people have buggered just drop me a line and i will break some for you ,im good at that

[Raziel]

I'm sorry that I need to resurect this 2 year old thread.. But I got some problems with that code
Everytime when I put it in, I get no errors. But when I fire the weapons inside the game. I cant hear them...
Any ideas why does that happens? on maybe someone can help me with it?
Thanks in advance.

-Raziel

[ronwolf1705]

::: CODE :::

void GunAttack (objtype *ob)
{
   objtype *check,*closest,*oldclosest;
   int damage;
   int dx,dy,dist;
   long viewdist;

                switch (gamestate.weapon)
   {
      case wp_pistol:
         SD_PlaySound (ATKPISTOLSND);
         break;
      case wp_machinegun:
         SD_PlaySound (ATKMACHINEGUNSND);
         break;
      case wp_chaingun:
         SD_PlaySound (ATKGATLINGSND);
         break;
   }
   
//
// find potential targets
//
   viewdist = 0x7fffffffl;
   closest = NULL;

   while (1)
   {
      oldclosest = closest;

      for (check=ob->next ; check ; check=check->next)
      if ( (check->flags & FL_SHOOTABLE) && (check->flags & FL_VISABLE) && abs (check->viewx-centerx) < shootdelta)
      {
         if (check->transx < viewdist)
         {
            viewdist = check->transx;
            closest = check;
         }
      }

      if (closest == oldclosest) return; // no more targets, all missed
//
// trace a line from player to enemey
//
      if (CheckLine(closest)) break;

   }

//
// hit something
//
   dx = abs(closest->tilex - player->tilex);
   dy = abs(closest->tiley - player->tiley);
   dist = dx>dy ? dx:dy;

   if (dist<2) damage = US_RndT() / 4;
   else if (dist<4) damage = US_RndT() / 6;
   else
   {
      if ( (US_RndT() / 12) < dist) return; // missed
      damage = US_RndT() / 6;
   }
   switch (gamestate.weapon)
   {
      case wp_pistol:
         damage = damage * 1.00;
         SD_PlaySound (ATKPISTOLSND);
         break;
      case wp_machinegun:
         damage = damage * 1.15;
         SD_PlaySound (ATKMACHINEGUNSND);
         break;
      case wp_chaingun:
         damage = damage * 10.50 + 100;
         SD_PlaySound (ATKGATLINGSND);
         break;
   }
   DamageActor (closest,damage);
}

Does this help?

[Raziel]

it doesnt matter anymore because I managed fixed it last night