DieHard Wolfers

[WLHack]

I have added new weapon but there is trange bug appearing,
when I pick up the item I can use it like normal weapon but
when I change to another weapon I can't change back the
weapon I added.

I have also added new GiveAmmo routine to support new ammotype
but I cannot shoot with the weapon using it if I haven't got ammo in
the other weapons too (and it seems like there can be unlimited amount
of ammo to this new ammotype).

Can anyone help me solve this/these problem/s?

[Dugtrio17]

Let's have a look at your WL_AGENT.C file. I'd specify a few functions, but for all we know it could be anywhere in it.

[WLHack]

Maybe I could sent my WL_AGENT_C file if someone is interested to take
a deeper look on it so the problems could be located and removed.

[WLHack]

Now nearly all the strange problems with ammo and weapons are solved.
Still I ask if anyone can help the "bug" appearing with the fifth gun
(when I pick up the item I can use it like normal weapon but
when I change to another weapon I can't change back the
weapon I added).

[Codetech84]

It seems your bug is in CheckWeaponChange function in WL_AGENT.C...

Let's have a look at it

[WLHack]

I haven't done any chances to it. Can you tell how should I chance it.

[Hair Machine]

Well, there's your answer. If you haven't changed the CheckWeaponChange function, then the game still thinks you can only select four weapons, as you could in the original game.

This is taken from the Wolf3d Dome and probably isn't the most optimised way of doing this, but it should work ok... possibly...

"Now do a search for CheckWeaponChange. Modify the entire little function to this (copy & paste)."

::: CODE :::

void CheckWeaponChange (void)
{
int i,buttons;
if (!gamestate.ammo) // must use knife with no ammo
return;
switch (LastScan)
{
case 2:
LastScan=0;
gamestate.weapon = gamestate.chosenweapon = wp_knife;
break;
case 3:
LastScan=0;
gamestate.weapon = gamestate.chosenweapon = wp_pistol;
break;
case 4:
LastScan=0;
if (gamestate.bestweapon >= wp_machinegun)
{
gamestate.weapon = gamestate.chosenweapon = wp_machinegun;
}
break;
case 5:
LastScan=0;
if (gamestate.bestweapon >= wp_chaingun)
gamestate.weapon = gamestate.chosenweapon = wp_chaingun;
}
break;
case 6:
LastScan=0;
if (gamestate.bestweapon >=wp_saw) // change this to your new gun
gamestate.weapon = gamestate.chosenweapon = wp_saw; // change this to your new gun
}
break;
}
DrawWeapon();
}

If it doesn't work right then... use magic. Or just change stuff until it does

[WLHack]

Thanks Hair Machine, finally I got rid of that bug.
Thank you again.

[WLHack]

Somehow the "infinite ammo bug" is still appearing
and I can't get rid of it.

I have made some research and I think there is something wrong
with this part of code but if it is not so, could you tell where is the
source of the problem then and how to fix it.

::: CODE :::

GunAttack (ob);
switch (gamestate.weapon)
{
     case wp_pistol:
     case wp_machinegun:
             gamestate.ammo--;          <-- 
             DrawAmmo ();
             break;
     case wp_chaingun:
     case wp_stengun:
             gamestate.ammo2--;        <-- Is these lines causing the bug
             DrawAmmo2 ();
             break;
}
break;

[Chris]

Ok man, I'd first recommend that you restrict ammo from subtracting when it's 0, then change the weapon so they can't use it.

Here's an example: http://diehardwolfers.areyep.com/viewtopic.php?t=2181&start=60#7

If you still get the infinate ammo bug, then your code probably isn't reaching parts of your switch at all for some reason (but I don't know how you have gamestate.ammo2 and wp_stengun set up, and how many weapons have this bug, so I probably couldn't be too much help yet in this case).

[WLHack]

Well this didn't work but thanks anyway. Umm... I also noticed that
this bug appears only if I have a weapon using ammo1 and a weapon
using ammo2 at the same time, otherwise it won't appear.

This I mean that if I only got pistol or machinegun (ammo1) I can shoot
them till I run out of ammo and then the game chances weapon to knife
till I found more ammo.

If I only got chaingun and stengun (ammo2) I can shoot them till I run out of
ammo etc... etc...

My gamestate.ammo2, is nearly a exact copy of gamestate.ammo,
only difference is it use GiveAmmo2 and DrawAmmo2 to handle weapon
firing rate.

[Chris]

I'm still confused about one thing. So you're saying, when you have ammo in both, it doesn't switch to the knife; and instead keeps firing? The ammo still decreases to 0 though right? Or does it not decrease at all for either ammo or ammo2 (or both) when you have ammo in both types?

If it's the former, maybe you have a "!gamestate.ammo && !gamestate.ammo2" if statement somewhere that's suppose to be something else like "||"; or vice versa? If the latter, maybe you have something that also increases the ammo when it decreases it? I don't know, but either of these would be easy to fix; you can even cheat and just add another line of code to restrict those from happening if you really want.

Would be easier to see your entire T_Attack function, and maybe some other sections that you changed; just to see what you did. With a little work at trying to understand what you did (and understanding what everything you did causes), I'm sure you/we can fix this bug pretty easily.

[WLHack]

Yes, that is exactly what I am saying. When amount of ammo reaches zero
it starts to increase till it is 99 and then it returns zero again (this is somekind
of a loop).

Here is my T_Attack function, I hope it helps to understand the
situation.

::: CODE :::

/*
===============
=
= T_Attack
=
===============
*/

void   T_Attack (objtype *ob)
{
   struct   atkinf   *cur;

   UpdateFace ();

   if (gamestate.victoryflag)      // watching the BJ actor
   {
      VictorySpin ();
      return;
   }

   if ( buttonstate[bt_use] && !buttonheld[bt_use] )
      buttonstate[bt_use] = false;

   if ( buttonstate[bt_attack] && !buttonheld[bt_attack])
      buttonstate[bt_attack] = false;

   ControlMovement (ob);
   if (gamestate.victoryflag)      // watching the BJ actor
      return;

   plux = player->x >> UNSIGNEDSHIFT;         // scale to fit in unsigned
   pluy = player->y >> UNSIGNEDSHIFT;
   player->tilex = player->x >> TILESHIFT;      // scale to tile values
   player->tiley = player->y >> TILESHIFT;

//
// change frame and fire
//
   gamestate.attackcount -= tics;
   while (gamestate.attackcount <= 0)
   {
      cur = &attackinfo[gamestate.weapon][gamestate.attackframe];
      switch (cur->attack)
      {
      case -1:
         ob->state = &s_player;
         if (!gamestate.ammo)
         if (!gamestate.ammo2)
         {
            gamestate.weapon = wp_knife;
      //      DrawWeapon ();
         }
         else
         {
            if (gamestate.weapon != gamestate.chosenweapon)
            {
               gamestate.weapon = gamestate.chosenweapon;
      //         DrawWeapon ();
            }
         };
         gamestate.attackframe = gamestate.weaponframe = 0;
         return;

      case 4:
         if (!gamestate.ammo)
         if (!gamestate.ammo2)
            break;
         if (buttonstate[bt_attack])
            gamestate.attackframe -= 2;
      case 1:
         if (!gamestate.ammo)
         if (!gamestate.ammo2)
         {   // can only happen with chain gun
            gamestate.attackframe++;
            break;
         }
         GunAttack (ob);
         switch (gamestate.weapon)
         {
             case wp_pistol:
             case wp_machinegun:
            gamestate.ammo--;
            DrawAmmo ();
            break;
             case wp_chaingun:
             case wp_stengun:
             gamestate.ammo2--;
             DrawAmmo2 ();
             break;
         }

      case 2:
         KnifeAttack (ob);
         break;

      case 3:
         if (gamestate.ammo && buttonstate[bt_attack])
            gamestate.attackframe -= 2;
         break;
      }

      gamestate.attackcount += cur->tics;
      gamestate.attackframe++;
      gamestate.weaponframe =
         attackinfo[gamestate.weapon][gamestate.attackframe].frame;
   }

}

[Chris]

Ok, from what I can tell, your "case -1" should probably start with something more like:

::: CODE :::

   case -1:
      ob->state = &s_player;
      if (!gamestate.ammo || !gamestate.ammo2)
      {
         if (gamestate.ammo)
            if (gamestate.weapon >= wp_chaingun)
               gamestate.weapon = wp_pistol;
         else
            if (!gamestate.ammo2)
               gamestate.weapon = wp_knife;
      //   DrawWeapon ();
      }
      else

::: CODE :::

   case -1:
      if (gamestate.ammo < 0) gamestate.ammo = 0;
      if (gamestate.ammo2 < 0) gamestate.ammo2 = 0;
      ob->state = &s_player;

The blue code just takes into consideration if your ammo is below 0 once you stop shooting (which shouldn't be needed if the other cases work correctly), but I thought I'd post it anyway if you wanted to test it somewhere. The red code will switch your weapon to something lower if you have no ammo in your current weapon (I don't know how you're detecting if a player has gotten the machine gun, so I just kept it as wp_pistol when you run out of ammo2).

I'm not too sure about your "case 4" and "case 1" either; I'd probably change them to something like this:

::: CODE :::

   case 4:
      if (gamestate.weapon >= wp_chaingun && !gamestate.ammo2)
         break;
      if (buttonstate[bt_attack])
         gamestate.attackframe -= 2;
   case 1:
      if (gamestate.weapon >= wp_chaingun && !gamestate.ammo2)
      {   // can only happen with chain gun
         gamestate.attackframe++;
         break;
      }
      GunAttack (ob);

You may want to change the ">= wp_chaingun to "== wp_chaingun" if you find that the stengun isn't acting the way you wanted. At first I would have added some extra "gamestate.weapon < wp_chaingun && !gamestate.ammo" expressions to those if statements, but it doesn't look like it matters for either (since chaingun is the only one that spits out two shots in one sitting and the rest is caught by "case -1").

If you can still press 2 or 4 (for example) when you have 0 ammo, you might need to alter the line Hair Machine posted a little as well:

::: CODE :::

void CheckWeaponChange (void)
{
   int i,buttons;

   // this check removed because it's detected below

   switch (LastScan)
   {
      case 2:
         LastScan=0;
         gamestate.weapon = gamestate.chosenweapon = wp_knife;
         break;
      case 3:
         LastScan=0;
         if (gamestate.ammo)
            gamestate.weapon = gamestate.chosenweapon = wp_pistol;
         break;
      case 4:
         LastScan=0;
         if (gamestate.bestweapon >= wp_machinegun && gamestate.ammo)
            gamestate.weapon = gamestate.chosenweapon = wp_machinegun;
         break;
      case 5:
         LastScan=0;
         if (gamestate.bestweapon >= wp_chaingun && gamestate.ammo2)
            gamestate.weapon = gamestate.chosenweapon = wp_chaingun;
         break;
      case 6:
         LastScan=0;
         if (gamestate.bestweapon >= wp_stengun && gamestate.ammo2)
            gamestate.weapon = gamestate.chosenweapon = wp_stengun;
         break;
   }
   DrawWeapon();

}

Well anyway, let me know if those ideas make things run better, or what happends after you use them.

edit: Somehow I erased this post when trying to make a new one, but managed to recover it from a backup window. Heh.

[WLHack]

Well, now weapons chaingun and stengun works properly
but pistol and machinegun has still got the same problem,
but again thank Chris.

[Chris]

Ok, cool WLHack.
What happends when you add the lines in blue above "ob->state = &s_player"? Does it make the pistol work any better?

Chris wrote:

At first I would have added some extra "gamestate.weapon < wp_chaingun && !gamestate.ammo" expressions to those if statements, but it doesn't look like it matters for either (since chaingun is the only one that spits out two shots in one sitting and the rest is caught by "case -1").

I don't know if this above idea will help, but if you still want to try it; the code would look something like this:

::: CODE :::

   case 4:
      if ((gamestate.weapon >= wp_chaingun && !gamestate.ammo2) || (gamestate.weapon < wp_chaingun && !gamestate.ammo))
         break;
      if (buttonstate[bt_attack])
         gamestate.attackframe -= 2;
   case 1:
      if ((gamestate.weapon >= wp_chaingun && !gamestate.ammo2) || (gamestate.weapon < wp_chaingun && !gamestate.ammo))
      {   // can only happen with chain gun
         gamestate.attackframe++;
         break;
      }
      GunAttack (ob);

Any more luck yet? If not, I'm sure we can just use a similar line as the blue one somewhere else to restrict them.

[WLHack]

Thanks Chris, now the weapons works without major bugs,
this really helped me so Thanks again.